Re: [PATCH v4 16/20] tools/testing/selftests/mm: test anonymous page offset merge behaviour

"Lorenzo Stoakes (ARM)" <[email protected]> Wed, 12 Aug 2026 18:24:27 +0100

Newsgroups	org.kernel.vger.linux-fsdevel,org.freedesktop.lists.amd-gfx,org.freedesktop.lists.dri-devel,org.freedesktop.lists.intel-xe,org.kernel.vger.kvm,org.kernel.vger.linux-kernel,org.kernel.vger.linux-kselftest,org.kernel.vger.linux-perf-users,org.kernel.vger.linux-s390,org.kernel.vger.linux-trace-kernel,org.kvack.linux-mm
Message-ID	<anysQa1hC83cdX_7@lucifer>

On Tue, Aug 11, 2026 at 01:08:32PM -0700, Andrew Morton wrote:
> On Tue, 11 Aug 2026 18:07:36 +0100 "Lorenzo Stoakes (ARM)" <[email protected]> wrote:
>
> > > "Fault in" is imprecise, as a read-fault won't do. "Trigger a CoW fault." might
> > > be better.
> >
> > Andrew - could you fix up? Thanks :)
>
> np.
>
> --- a/tools/testing/selftests/mm/merge.c~tools-testing-selftests-mm-test-anonymous-page-offset-merge-behaviour-fix
> +++ a/tools/testing/selftests/mm/merge.c
> @@ -1324,7 +1324,7 @@ TEST_F(merge, anon_and_page_offset_misma
>  	ASSERT_NE(ptr, MAP_FAILED);
>
>  	/*
> -	 * Map another separately, and fault in, at page offset 5:
> +	 * Map another separately and trigger a CoW fault, at page offset 5:
>  	 *
>  	 * |-----------|           |---------|
>  	 * | unfaulted |           | faulted |
> _
>

LGTM thanks very much! :)

--
Cheers, Lorenzo