Re: [PATCH v2 0/4] sysctl: Disallow partial updates of miss-formatted sysctl vectors

Joel Granados <[email protected]> Mon, 17 Aug 2026 16:02:27 +0200

Newsgroups	org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-kernel,org.kernel.vger.linux-kselftest,org.kvack.linux-mm
Message-ID	<gxiyb2aye6vvu6t7veykvptj4t3hxll67mugievbumjc6krstw@nivusuyqhpbr>

On Fri, Aug 14, 2026 at 12:41:11PM +0200, Joel Granados wrote:
> What?
> =====
> 
> Stage table->data when writing INT & ULONG ctl_tables. Commit staged
> data to kernel variable only when all the conversions have succeeded.
> This is applicable only to variables that represent a vector; paths
> pertaining to scalers are left unchanged. Notice that partial updates
> can still happen if less than the size of the vector are passed and
> correctly formatted.
... snip ...
>       sysctl: Split data conversion and file position handling
>       sysctl: Reject uint arrays before calling the general proc_vec
>       sysctl: Disallow partial updates for erroneous sysctl vectors
>       sysctl: Add 0013 to test partially updated vectors
> 
>  kernel/sysctl.c                          | 237 ++++++++++++++++++++-----------
>  tools/testing/selftests/sysctl/sysctl.sh |  60 ++++++++
>  2 files changed, 217 insertions(+), 80 deletions(-)
> ---
> base-commit: 4c12287001da60f3c022bb25932aa7a5590fc0b1
> change-id: 20260813-lklm-partial_ctlvec-bd8867b70d5c
> 
> Best regards,
> -- 
> Joel Granados <[email protected]>
> 
> 

I feel the superficial changes mentioned in the review (up until now) do
not merit me sending a V3. The modified tree is here [1]. 

Best

[1] https://git.kernel.org/pub/scm/linux/kernel/git/joel.granados/linux.git/log/?h=jag/partial_ctlvec

signature.asc (application/pgp-signature, 659 B)