Re: [PATCH v2 0/4] sysctl: Disallow partia l updates of miss-formatted sysctl vectors
Bradley Morgan <[email protected]>
| Newsgroups | org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-kernel,org.kernel.vger.linux-kselftest,org.kvack.linux-mm |
|---|---|
| Message-ID | <[email protected]> |
On 18 August 2026 13:46:58 BST, Joel Granados <[email protected]> wrote: >On Sat, Aug 15, 2026 at 05:09:30PM +0100, Bradley Morgan wrote: >> >> Copy it, only write back once every value converted. That's the >> right way to do this. Went through the whole series against the >> tree, notes in the patch replies. >Your feedback was useful, but it was riddled with a *lot* of hand >waving. Please be succinct and to the point. The previous paragraph is >not needed. > >> >> Some nits on the series: >> - "miss-formatted" in the subject. mis-formatted, or just malformed. >Note that this comment is missing the why. It is good to know why you >want the change > >> - akpm's scalars nit still applies. >> - Sashiko saw something on this one (akpm linked it). >In my opinion this is just noise. If you see that I have missed a >comment, call me out on it. If you have additional information, answer >to reviewers mail. > >> >> Otherwise fine by me, the split is clean. >> >> >> Reviewed-by: Bradley Morgan <[email protected]> >> also >> >> Tested-by: Bradley Morgan <[email protected]> for the test >How did you test? And what where your results? > Built and booted the latest kernel. Its the summer holidays, I can do all this, it's magical >Best > Thanks!