Re: [PATCH 4/4] smb: prevent TIF_NOTIFY_SIGNAL from interrupting

Paulo Alcantara <[email protected]>
Newsgroups org.kernel.vger.linux-fsdevel,org.kernel.vger.bpf,org.kernel.vger.linux-cifs,org.kvack.linux-mm
Message-ID <[email protected]>
Christian Brauner <[email protected]> writes:

> smb_send_kvec() blocks every signal during a send:
>
> 	sigfillset(&mask);
> 	sigprocmask(SIG_BLOCK, &mask, &oldmask);
>
> An incomplete or partial sent would cause the connection to become out
> of sync. That in turn would cause the session to be torn down and
> reconnected.
>
> In 00be6f26a2a7 ("smb: client: transport: avoid reconnects triggered
> by pending task work") smb hand-rolled its own solution. Have it use the
> new no_notify_signal_save() critical section instead.
>
> This stops io_uring from cancelling a send in flight but that's just
> like it is today and it is bounded by sk_sndtimeo at around 15s.
>
> Signed-off-by: Christian Brauner (Amutable) <[email protected]>

Acked-by: Paulo Alcantara <[email protected]>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.