Re: [PATCH v5 08/17] LoongArch: kexec_file: Fix a modified_cmdline leak
| Newsgroups | org.kernel.vger.linux-fsdevel,dev.linux.lists.driver-core,dev.linux.lists.loongarch,org.kernel.vger.linux-kernel,org.kvack.linux-mm,org.ozlabs.lists.linuxppc-dev |
|---|---|
| Message-ID | <[email protected]> |
> load_other_segments() allocates modified_cmdline and stores it in > image->arch.cmdline_ptr. machine_kexec_prepare() then copies it to > KEXEC_CMDLINE_ADDR and overwrites the pointer, so the heap buffer is > leaked on every successful kexec_file_load(). > > Free the buffer after the copy. > > Cc: Huacai Chen <[email protected]> > Cc: WANG Xuerui <[email protected]> > Cc: Kexin Liu <[email protected]> > Cc: Youling Tang <[email protected]> > Cc: Qiang Ma <[email protected]> > Cc: Tianyang Zhang <[email protected]> > Cc: George Guo <[email protected]> > Cc: [email protected] > Fixes: d162feec6b6e ("LoongArch: Add preparatory infrastructure for kexec_file") > Signed-off-by: Jinjie Ruan <[email protected]> Sashiko has reviewed this patch and found no issues. It looks great! -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=8