Re: [PATCH] sysctl: quiet unused variable warning in fs/proc/proc_sysctl.c:init_header()

Joel Granados <[email protected]> Fri, 18 Sep 2026 13:05:00 +0200

Newsgroups	org.kernel.vger.linux-fsdevel
Message-ID	<iguoigeao5itgylh6kmzwiiuwk4pqra32vpqvyv2ingitchs4w@pctwdteu52mh>

On Thu, Sep 17, 2026 at 11:23:38PM -0700, Ethan Nelson-Moore wrote:
> The init_header() function uses list_for_each_table_entry() without
> using the entry argument. This causes a warning when building with W=1.
> Since the code is correct, mark the associated variable as
> __maybe_unused.

I'm probably compiling in a different way but I don't see that warning.
Can you please tell me how you compile, what are you are in. What
version of compiler are you running?

Thx
> 
> Signed-off-by: Ethan Nelson-Moore <[email protected]>
> ---
>  fs/proc/proc_sysctl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c
> index 04a382178c65..d0d76c31d330 100644
> --- a/fs/proc/proc_sysctl.c
> +++ b/fs/proc/proc_sysctl.c
> @@ -206,7 +206,7 @@ static void init_header(struct ctl_table_header *head,
>  	head->node = node;
>  	INIT_HLIST_HEAD(&head->inodes);
>  	if (node) {
> -		const struct ctl_table *entry;
> +		const struct ctl_table *entry __maybe_unused;
>  
>  		list_for_each_table_entry(entry, head) {
>  			node->header = head;
> -- 
> 2.43.0
>

signature.asc (application/pgp-signature, 659 B)