[PATCH v2 2/4] gpiolib: of: compile of_find_trigger_gpio() conditionally
Dmitry Torokhov <[email protected]>
| Newsgroups | org.kernel.vger.linux-gpio,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Compile of_find_trigger_gpio() and include its entry in the of_find_gpio_quirks table only when CONFIG_LEDS_TRIGGER_GPIO is enabled, and remove the redundant runtime check. Assisted-by: Antigravity:gemini-3.5-flash Signed-off-by: Dmitry Torokhov <[email protected]> --- v2: no changes drivers/gpio/gpiolib-of.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c index fc77cf6b306a..f4ea7ca27296 100644 --- a/drivers/gpio/gpiolib-of.c +++ b/drivers/gpio/gpiolib-of.c @@ -651,6 +651,7 @@ static struct gpio_desc *of_find_mt2701_gpio(struct device_node *np, } #endif +#if IS_ENABLED(CONFIG_LEDS_TRIGGER_GPIO) /* * Trigger sources are special, they allow us to use any GPIO as a LED trigger * and have the name "trigger-sources" no matter which kind of phandle it is @@ -664,9 +665,6 @@ static struct gpio_desc *of_find_trigger_gpio(struct device_node *np, { struct gpio_desc *desc; - if (!IS_ENABLED(CONFIG_LEDS_TRIGGER_GPIO)) - return ERR_PTR(-ENOENT); - if (!con_id || strcmp(con_id, "trigger-sources")) return ERR_PTR(-ENOENT); @@ -676,6 +674,7 @@ static struct gpio_desc *of_find_trigger_gpio(struct device_node *np, return desc; } +#endif typedef struct gpio_desc *(*of_find_gpio_quirk)(struct device_node *np, @@ -687,7 +686,9 @@ static const of_find_gpio_quirk of_find_gpio_quirks[] = { #if IS_ENABLED(CONFIG_SND_SOC_MT2701_CS42448) of_find_mt2701_gpio, #endif +#if IS_ENABLED(CONFIG_LEDS_TRIGGER_GPIO) of_find_trigger_gpio, +#endif NULL }; -- 2.55.0.229.g6434b31f56-goog