Re: [PATCH] gpio: realtek-otto: add pinctrl support

On Sun, Jul 26, 2026 at 06:38:00PM +0200, Linus Walleij wrote:
> On Sun, Jul 26, 2026 at 5:21 PM Michael Zavertkin
> <[email protected]> wrote:
> 
> > Should I also add pinctrl property to required in realtek,otto-gpio.yaml
> > for realtek,rtl9607-gpio?
> 
> What do you mean? You should use gpio-ranges so add that if
> you don't have it already:
> 
> gpio-ranges: true
> 
> After adding appropriate gpio-ranges to your DTS the pin controller
> will become a back-end for the gpio. But certainly you must have
> done that already?
> 
> Yours,
> Linus Walleij
Yes, there is gpio-ranges in .dts I tested.
I meant should correspondig 'required' property be added to
realtek,otto-gpio documentation? Just like that:

--- a/Documentation/devicetree/bindings/gpio/realtek,otto-gpio.yaml
+++ b/Documentation/devicetree/bindings/gpio/realtek,otto-gpio.yaml
@@ -40,6 +40,8 @@ properties:

   gpio-controller: true

+  gpio-ranges: false
+
   ngpios:
     minimum: 1
     maximum: 32
@@ -75,6 +77,18 @@ required:
   - "#gpio-cells"
   - gpio-controller

+allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: realtek,rtl9607-gpio
+    then:
+      properties:
+        gpio-ranges: true
+      required:
+        - gpio-ranges
+
 additionalProperties: false

 dependencies:

It is required for RTL9607C, otherwise controller won't be connected to
SoC pins and GPIOs won't work.
AFAIK, it should be a separate patch (but same patch series?)
If it's okay, I'll add it to v2