Re: [PATCH] gpio: sloppy-logic-analyzer: fix use-after-free via debugfs trigger on unbind
Wolfram Sang <[email protected]> Tue, 28 Jul 2026 11:47:35 +0200
| Newsgroups | org.kernel.vger.linux-gpio,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <amh6txid90mJjd62@shikoro> |
> debugfs_create_file_unsafe("buf_size", 0600, priv->debug_dir, priv, &fops_buf_size);
> debugfs_create_file_unsafe("capture", 0200, priv->debug_dir, priv, &fops_capture);
> - debugfs_create_file_unsafe("trigger", 0200, priv->debug_dir, priv, &fops_trigger);
> + debugfs_create_file("trigger", 0200, priv->debug_dir, priv, &fops_trigger);
What about removing the other _unsafe calls as well? TBH, I can't recall
why I used them. Doesn't make sense from today's perspective.
signature.asc
(application/pgp-signature, 833 B)
-----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmpoercACgkQFA3kzBSg KbZTbBAAl8lD0ZaYIS0xE9qghmAFaUtmCNpnOEzGTpGus3+4eMcitGSq/UcDOKMz 50vSFArOXOJNJP49zJIp7IGMwX+qLgmFdu1LiE4dUNZLXu+98TsO5U22GtdoszPP L8xxPfaKLWLKq11NWUs+EpnRbk/1NMgKIPLVSlXkq12mOnKoMlyKpUDnNZLtzuqy 01GKaCo2BKNFKpYrpzFsZVc72Kc8LFRyhq3GYY5eOHJAsIEbuI762LHGuRL4op8E fPpkKUS3+EkZqglPpStvR+kpqnVztDO0WfVlmINfU5BNB+U06LEf+rkeLkH08D2Z zUnx/TeB2QNhcBIkSDBEh4Y3W19T8xShkmds8EyjdVmQuRPvIGFi7InkQhp448lk HlRIpLXeMaHsBlKy7koxGFXQLZFiUPIRsZRVHLxVd3Ll2RTCHsJ1fE3Nb2gBHYZB K0tB1Em+tvjF4Ek+VrqVZ0vf1/jqUNc+JE5NmrmeOQfpwpSM67jLP9dUESTSGqR5 nNqCZRPAZAl+ccNnPvbo5n3LLAovtEUY8z8iBBVCrWjD9190TKjp60Bg1/YOyIPX 4y/gzE0JK/bzLu99rQXxFaTK0EHOE9zAlExGxbSBcbht+PaTOW4wm506FxHhKiHO W3HnUtLPRO3xKxFl+qOScS+SImPm1NEYUBBvzlz+tjgQ1M3GUhk= =jBkq -----END PGP SIGNATURE-----