Re: [PATCH] gpio: sloppy-logic-analyzer: fix use-after-free via debugfs trigger on unbind

Wolfram Sang <[email protected]> Wed, 29 Jul 2026 01:38:36 +0200

Newsgroups	org.kernel.vger.linux-gpio,org.kernel.vger.linux-kernel
Message-ID	<amk9fLBRR0B-uNpP@shikoro>

> Switching them to debugfs_create_file() would just add a second
> get/put around the one they already do, so I would leave them. 
> 
> Happy to send a follow-up if you'd prefer them consistent.

I would prefer them to be consistent. The overhead is negligible IMO.

If you prefer to leave them, ok, too. Then, I'd just ask you to add a
comment why this one file is different than the others. Because it
stands out and it is not directly obvious why.

Thank you for looking into this!

signature.asc (application/pgp-signature, 833 B)