Re: [PATCH v2 2/2] gpio: sloppy-logic-analyzer: use debugfs_create_file() for buf_size and capture

Wolfram Sang <[email protected]> Sat, 1 Aug 2026 22:36:02 +0200
Newsgroups org.kernel.vger.linux-gpio,org.kernel.vger.linux-kernel
Message-ID <am5YsrOS3lmDwJh4@shikoro>
--m4xUjN+nZ6XlrdFH
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jul 31, 2026 at 01:02:58AM +0300, Cengiz Can wrote:
> The "buf_size" and "capture" debugfs files are created with
> debugfs_create_file_unsafe() and DEFINE_DEBUGFS_ATTRIBUTE() fops. That is
> safe on its own: debugfs_attr_read()/write() take a debugfs reference
> themselves, so debugfs_remove_recursive() drains them on removal.
>=20
> Now that "trigger" uses debugfs_create_file(), switch these two to the
> same call so all three debugfs files in this driver are created uniformly.
> This is a cosmetic change; the extra debugfs_file_get()/put() added by the
> full_proxy wrapper is negligible.
>=20
> Suggested-by: Wolfram Sang <[email protected]>
> Assisted-by: Claude:claude-opus-4.8
> Signed-off-by: Cengiz Can <[email protected]>

I'd squash the patches and keep the stable tag for the combined patch,
but I'll leave this to the GPIO maintainers.

Reviewed-by: Wolfram Sang <[email protected]>


--m4xUjN+nZ6XlrdFH
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmpuWLIACgkQFA3kzBSg
KbYqtBAArSZGTU0TE6CqxvdXf+fY9WbViTUupwT/5+jihHKaXZDHZPgS9+oZ5ZiE
6dR4LwAU4HiWJan2WshypZlfaDBZwDo0mNL+IIFggK6vHMWBFGTL4PWsSzna3hKD
rMwOK9+kjJaj8RrFP86fXQHq3RiWh5D7xtE1uO6Af3BXE/ami7XkSZ4E14I0WdTZ
gYj937nnrWsdTLEV0FA1ivlU6Dq7zS7NoVpFnm/lQx7ZpXWDXz9jNifEfRUhV9/F
7WmW1GuAVFtG6HThe9x4mkRHHZpF++C3rUjEfcvMqJ9SeWaqCA5AC56IcZVs7BfT
J+MuvQbcvYj7/6MrP/5xN6XBXWALeGCXgkyUddZW2BQ3B/JVbymRYMx/mhVtyNd8
uRLojVZhzIA7VDKXOdxQP5Kyax2lwXZ5MIyuUv0j/4kVc7GdrHEu/yYGH2uHqPjn
+HGa5aJ0VilwqHAcPNCPnBlCj4hBVEMRDX57ftMAS+lYGKwpx6VEbooqdKdXrYSF
C6txBLQtuFrUsxJrvH0slkg+SWuIf6mSudVokGoJjbaBLXRVQFv/4BdXvvjEWEDN
KbYIEomVx6JIR2jCYLsoELa8rWAelj8ZZS6E9MstwqCZWFkD3U4Ko81pCGpZeJpC
07HnQxWbBx5TBCQP59C71v37dq5wIjvR1dpkbsX3+n7D6su074g=
=5BTl
-----END PGP SIGNATURE-----

--m4xUjN+nZ6XlrdFH--