Re: [PATCH v4 04/21] pinctrl: starfive: Add StarFive JHB100 sys0 controller driver

Linus Walleij <[email protected]> Tue, 4 Aug 2026 22:30:59 +0200

Newsgroups	org.kernel.vger.linux-gpio,org.infradead.lists.linux-riscv,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel
Message-ID	<CAD++jLmbuS-Tx82AZzwJZ=ANVwi3XVtYL3J4VYaE3yEZBumZ0Q@mail.gmail.com>

Hi Changhuang,

On Sat, Aug 1, 2026 at 9:27 AM Changhuang Liang
<[email protected]> wrote:

> Add pinctrl driver for StarFive JHB100 SoC System-0(sys0) pinctrl
> controller.
>
> Simultaneously add a generic pinctrl driver framework for registering
> the pinctrl of other domains (sys1, sys2, and so on) in the JHB100 SoC.
>
> Co-developed-by: Lianfeng Ouyang <[email protected]>
> Signed-off-by: Lianfeng Ouyang <[email protected]>
> Signed-off-by: Alex Soo <[email protected]>
> Signed-off-by: Changhuang Liang <[email protected]>

With Uwe's and Philipp's comments addressed this looks very nice.
I really like how you use all helper libraries in this driver!

Once DT bindings and comments are accepted, this can be merged.

Yours,
Linus Walleij