Re: [RESEND V2 2/2] pinctrl: tegra264: fix DAP2 DIN/DOUT pin assignment
Linus Walleij <[email protected]>
| Newsgroups | org.kernel.vger.linux-gpio,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-tegra |
|---|---|
| Message-ID | <CAD++jLkY-r8QYT0_tr=CDKxqG7HdOmuxgBL3F-Y3KmR6iLbqSg@mail.gmail.com> |
On Mon, Jul 27, 2026 at 4:11 PM Prathamesh Shete <[email protected]> wrote: > The dap2_din and dap2_dout pin groups were given swapped ball suffixes: > DAP2_DIN was described as ball PV7 and DAP2_DOUT as ball PW0. On silicon > DAP2_DIN is on ball PW0 (mux register 0x6050, drive register 0x6054) and > DAP2_DOUT is on ball PV7 (mux register 0x6058, drive register 0x605c), > as reflected by the board pinmux. > > Because the ball suffixes were swapped, the groups were also assigned the > wrong primary mux functions (dap2_din -> I2S2_SDATA_OUT and dap2_dout -> > I2S2_SDATA_IN), routing the I2S2 data-in and data-out signals to the wrong > pins and breaking DAP2 audio. > > Rename the groups to dap2_din_pw0 and dap2_dout_pv7 and give each pad its > correct function (dap2_din_pw0 -> I2S2_SDATA_IN, dap2_dout_pv7 -> > I2S2_SDATA_OUT). The register offsets are already correct and are left > unchanged. This matches the board pinmux. > > Fixes: c98506206912 ("pinctrl: tegra: Add Tegra264 pinmux driver") > Signed-off-by: Prathamesh Shete <[email protected]> Patch applied! Yours, Linus Walleij