[PATCH 01/10] dt-bindings: pinctrl: qcom,tlmm-common: allow functions on the HSIC pins
Dmitry Baryshkov <[email protected]>
| Newsgroups | org.kernel.vger.linux-gpio,org.infradead.lists.linux-phy,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-usb |
|---|---|
| Message-ID | <[email protected]> |
The common TLMM state schema requires the function property for GPIO pins and forbids it for all special pins. That rule is wrong for the MSM8974 HSIC pads: unlike the SDC pads, hsic_data and hsic_strobe are muxable pin groups (between the gpio and hsic_ctl functions, see HSIC_PINGROUP in pinctrl-msm8x74.c), and the msm8974 schema already lists hsic_ctl in its function enum. As a result any valid HSIC pinctrl state fails validation. Extend the function-required conditional to cover the HSIC pins and add the now-required function to the msm8974 example. Assisted-by: Claude:claude-fable-5 Signed-off-by: Dmitry Baryshkov <[email protected]> --- Documentation/devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.yaml | 1 + Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.yaml index a9aff442824c..d9178b265268 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.yaml @@ -161,5 +161,6 @@ examples: hsic-state { pins = "hsic_data", "hsic_strobe"; + function = "hsic_ctl"; }; }; diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml index aec72e8c0621..e10aff02be89 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml @@ -95,7 +95,7 @@ $defs: properties: pins: items: - pattern: "^gpio" + pattern: "^(gpio|hsic)" then: required: - function -- 2.47.3