Re: [PATCH v3 0/9] iio: adc: Add TI ADS126X ADC family support
David Lechner <[email protected]>
| Newsgroups | org.kernel.vger.linux-gpio,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-iio,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 8/9/26 3:29 AM, Kurt Borja wrote: > On Sat Aug 8, 2026 at 1:37 PM -05, David Lechner wrote: >> On 8/7/26 10:58 PM, Kurt Borja wrote: >> ... >> >> And the driver also allows using an hrtimer trigger to do single-shot >> samples for cases where one doesn't want to sample as fast as possible >> in continuous mode. This would be more useful to someone who just cares >> about sample rate and not about filtering. > > Why did you go for this instead of just leaving the continuous mode > running and reading on each trigger? The hrtimer trigger allows more than one channel to be enabled, so we have to do all of the channel setup for the next channel before we can send the start command to trigger the next conversion. Doing it this way eliminates the possibility of not being able to update all of the settings in between the DRDY interrupts. For cases where we only want to read one channel, then we can use the DRDY trigger instead of an hrtimer trigger. Since we don't have to change channel config in that case, if we miss a DRDY interrupt because we took to long to start the I2C transfer, it isn't a big deal, we just drop a sample. > >> >> Just posted the series yesterday: >> https://lore.kernel.org/linux-iio/20260807-iio-adc-ti-ads112c14-filter-support-v1-0-4d3ba00caf18@baylibre.com/T/#t > > Can you Cc me this series too? The settlingtime stuff is something I'll > implement too. Yes, I meant to. It was late on a Friday when I sent it and I didn't the best job checking all of the details like that.