Re: [PATCH 07/15] interconnect: qcom: Add Kuno interconnect provider driver

On Tue, Aug 11, 2026 at 09:17:08AM +0530, Hardeep Sharma wrote:
> 
> On 8/11/2026 6:30 AM, Dmitry Baryshkov wrote:
> > On Sun, Aug 09, 2026 at 12:57:06PM +0530, Hardeep Sharma wrote:
> > > Add the interconnect provider driver for the Qualcomm Kuno SoC to
> > > enable bus bandwidth voting on the platform. This includes the
> > > aggre-noc and cnoc-main NoC instances with their associated BCM
> > > nodes.
> > > 
> > > Signed-off-by: Hardeep Sharma <[email protected]>
> > > ---
> > >   drivers/interconnect/qcom/Kconfig  |  13 +
> > >   drivers/interconnect/qcom/Makefile |   2 +
> > >   drivers/interconnect/qcom/kuno.c   | 978 +++++++++++++++++++++++++++++++++++++
> > >   3 files changed, 993 insertions(+)
> > Please add QoS settings.
> > 
> Thanks for review.
> 
> Kuno's NoC QoS is provisioned by RPMh/boot firmware, the same as its SDX75
> baseline.
> 
> The upstream sdx75 interconnect driver programs no AP-side QoS and only
> issues BCM bandwidth votes; Kuno follows that precedent.
> 
> Hence no qcom_icc_qosbox settings and no QoS clocks in the binding —
> matching qcom,sdx75-*.

The QoS-related clocks are a part of the hardware description. Even if
they are not neccessary now, please add them to prevent future schema /
DT changes. See how it was happening to other (mobile) chips.

-- 
With best wishes
Dmitry