Re: [PATCH 11/15] clk: qcom: Add Global Clock Controller driver for Kuno

On 8/11/2026 6:36 AM, Dmitry Baryshkov wrote:
> On Sun, Aug 09, 2026 at 12:57:10PM +0530, Hardeep Sharma wrote:
>> Add the global clock controller (GCC) driver for the Qualcomm Kuno SoC,
>> providing the PLLs, root clock generators, gate/branch clocks and resets
>> used by the peripheral devices such as UART, SPI, I2C, USB, SD, PCIe and
>> Ethernet.
>>
>> Signed-off-by: Hardeep Sharma <[email protected]>
>> ---
>>   drivers/clk/qcom/Kconfig    |   10 +
>>   drivers/clk/qcom/Makefile   |    1 +
>>   drivers/clk/qcom/gcc-kuno.c | 1438 +++++++++++++++++++++++++++++++++++++++++++
>>   3 files changed, 1449 insertions(+)
>>
>> +static struct clk_alpha_pll gpll0 = {
>> +	.offset = 0x0,
>> +	.regs = clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_LUCID_EVO],
>> +	.clkr = {
>> +		.enable_reg = 0x7d000,
>> +		.enable_mask = BIT(0),
>> +		.hw.init = &(const struct clk_init_data){
>> +			.name = "gpll0",
>> +			.parent_data = &(const struct clk_parent_data){
> Whitespace between ) and { (through all the file).
>
>> +				.index = DT_BI_TCXO,
>> +			},
>> +			.num_parents = 1,
>> +			.ops = &clk_alpha_pll_fixed_lucid_evo_ops,
>> +		},
>> +	},
>> +};
>> +

Thanks for review.

Done in v2 : 
https://lore.kernel.org/all/[email protected]/

Best Wishes
Hardeep Sharma