Re: [PATCH 10/13] HID: ft260: uart: fix active-low RTS/CTS/DTR/DSR polarity
Linus Walleij <[email protected]>
| Newsgroups | org.kernel.vger.linux-gpio,org.kernel.vger.linux-i2c,org.kernel.vger.linux-input,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <CAD++jL=92mLe9w_VADZrSxPcban--S6LgsmpcPAHdLQ0yCZpHQ@mail.gmail.com> |
Hi Michael, thanks for your patch! On Sat, Aug 22, 2026 at 11:40 PM Michael Zaidman <[email protected]> wrote: > From: Rio Liu <[email protected]> > > The FT260 modem control GPIOs for RTS, CTS, DTR, and DSR are active-low. > Invert the TIOCMGET sense and the TIOCMSET drive levels for those pins > so userspace ioctl state matches the electrical lines. Leave DCD and RI > unchanged. > > Signed-off-by: Rio Liu <[email protected]> > Signed-off-by: Michael Zaidman <[email protected]> Isn't this just fixing a patch earlier in the same series? Just fold it in with the patch adding this. Note: GPIOlib has it's own polarity inversion handling, when you rewrite the serial modem control to use the helpers, the gpio table will include a flag for polarity inversion, and then you just put it there. Yours, Linus Walleij