Re: [PATCH net] netrom: do some basic forms of validation on incoming frames
Greg Kroah-Hartman <[email protected]> Fri, 10 Apr 2026 07:24:36 +0200
| Newsgroups | org.kernel.vger.linux-hams,org.kernel.vger.linux-kernel,org.kernel.vger.netdev |
|---|---|
| Message-ID | <2026041026-excuse-slashing-c4ee@gregkh> |
On Thu, Apr 09, 2026 at 08:32:35PM -0700, Jakub Kicinski wrote: > On Thu, 9 Apr 2026 20:03:28 +0100 Simon Horman wrote: > > I expect that checking skb->len isn't sufficient here > > and pskb_may_pull needs to be used to ensure that > > the data is also available in the linear section of the skb. > > Or for simplicity we could also be testing against skb_headlen() > since we don't expect any legit non-linear frames here? Dunno. I'll be glad to change this either way, your call. Given that this is an obsolete protocol that seems to only be a target for drive-by fuzzers to attack, whatever the simplest thing to do to quiet them up I'll be glad to implement. Or can we just delete this stuff entirely? :) thanks, greg k-h