Re: [PATCH net 1/1] net/rose: hold listener socket during call request handling
Simon Horman <[email protected]> Mon, 20 Apr 2026 17:26:05 +0100
| Newsgroups | org.kernel.vger.linux-hams,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
On Fri, Apr 17, 2026 at 07:01:51PM +0800, Ren Wei wrote: > From: Nan Li <[email protected]> > > The call request receive path keeps using the listener socket after the > lookup lock has been dropped. Keep the listener alive across the > remaining validation and child socket setup by taking a reference in the > lookup path and releasing it once request handling is finished. > > This makes listener lifetime handling explicit and avoids races with > concurrent socket teardown. > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Cc: [email protected] > Reported-by: Yifan Wu <[email protected]> > Reported-by: Juefei Pu <[email protected]> > Reported-by: Xin Liu <[email protected]> > Co-developed-by: Yuan Tan <[email protected]> > Signed-off-by: Yuan Tan <[email protected]> > Signed-off-by: Nan Li <[email protected]> > Signed-off-by: Ren Wei <[email protected]> > --- > net/rose/af_rose.c | 24 +++++++++++++++++++----- > 1 file changed, 19 insertions(+), 5 deletions(-) Reviewed-by: Simon Horman <[email protected]> Sachiko has provided some feedback on this patch. I do not believe they relate to shortcomings in this patch, and I do not believe they should block progress of this patch. You may want to look over them for areas to investigate as follow-up (maybe you already did :) ...