Re: [PATCH v6 1/6] iio: dac: ad5686: refactor command/data macros

On Sun, 5 Jul 2026 17:24:11 +0300
Andy Shevchenko <[email protected]> wrote:

> On Sun, Jul 05, 2026 at 12:38:56PM +0100, Rodrigo Alencar via B4 Relay wrote:
> 
> > Replace usage of bit shifting macros for FIELD_PREP(), which would not
> > ignore bit masking when preparing SPI/I2C commands.  
> 
> It's not marked as a fix and has no explanation why.
> 
Agreed - this needs to stand on its own as a description, without needing
to know this is both hardening code and closing down real issues with debugfs
(IIRC from the sashiko reports that lead to this).
Maybe sensible to add both a tag for sashiko suggesting / reporting it
and a link to that review.

Thanks,

Jonathan