Re: [PATCH v4 5/7] media: uapi: Add CAMSS ISP configuration definition

Hi Bryan,

On Fri, Jul 10, 2026 at 11:41 PM Bryan O'Donoghue
<[email protected]> wrote:
>
> On 10/07/2026 10:04, Loic Poulain wrote:
> > Add the uapi header camss-config.h defining the ISP parameter
> > structures used by the CAMSS Offline Processing Engine (OPE) driver.
> > This includes structures for white balance, chroma enhancement and
> > color correction configuration.
> >
> > Signed-off-by: Loic Poulain<[email protected]>
> > ---
> >   include/uapi/linux/camss-config.h | 161 ++++++++++++++++++++++++++++++++++++++
> >   1 file changed, 161 insertions(+)
> >
> > diff --git a/include/uapi/linux/camss-config.h b/include/uapi/linux/camss-config.h
>
> Why haven't you based this on the HFI stuff I supplied though ? Its the
> same hardware right ?

For the three introduced structures:
- camss_params_color_correct is the same as the one you supplied
- camss_params_wb_gain has three extra offset appended (post gain), as
supported by the hardware. But maybe the signed offsets you introduced
were supposed to support both pre/post based on the sign?
- camss_params_chroma_enhan is newly introduced here

Regards,
Loic