Re: [PATCH v8 2/8] iio: dac: ad5686: missing NULL check on match data

Joshua Crofts <[email protected]> Thu, 16 Jul 2026 21:08:29 +0200

Newsgroups	org.kernel.vger.linux-hardening,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-iio,org.kernel.vger.linux-kernel
Message-ID	<CALoEA-wQwxjG860Y9u-vBkGn=Y=82UBX4bG1rvaed_A-qZu6Yg@mail.gmail.com>

On Thu, 16 Jul 2026 at 20:42, Andy Shevchenko
<[email protected]> wrote:
>
> On Thu, Jul 16, 2026 at 01:14:18PM +0100, Rodrigo Alencar via B4 Relay wrote:
>
> > Verify that chip_info pointer is not NULL. If a user binds the driver
> > using driver_override via sysfs with a device name not present in the
> > id_table or of_match_table, match data will be NULL.
>
> ...
>
> >       struct iio_dev *indio_dev;
> >       int ret, i;
>
>
> Move an assignment here as well.
>
>         chip_info = ...
>
> > +     if (!chip_info)
> > +             return -ENODEV;
>

Enough reviewing for me today, considering I let this slip past me.

-- 
Kind regards

CJD