Re: [PATCH 5/7] arm64: dts: qcom: Add LeEco Le2

Dmitry Baryshkov <[email protected]>
Newsgroups org.kernel.vger.linux-hardening,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel
Message-ID <znkuidfiskzgl6qrt5hry4akmqtxkfswgz6v2jrwc7nvztecli@q543uz4p4knz>
On Mon, Aug 10, 2026 at 06:55:38PM +0200, Adam Skladowski wrote:
> Add a devicetree for the LeEco Le2 smartphone, which is based
> on the Eldarion/MSM8976 SoC.
> 
> Supported functionality as of this initial submission:
> * I2C peripherals (Touchscreen,Audio amp, Haptics, Extcon, Led)
> * Power Button, Volume Keys
> * Regulators (PM8950)
> * WLED (PMI8950)
> * Remoteprocs (WCNSS)
> * GPU
> 
> Device tree also contains supply maps to other subsystems like MDSS
> but due to missing dependencies like panel those are disabled.
> 
> Signed-off-by: Adam Skladowski <[email protected]>
> ---
>  arch/arm64/boot/dts/qcom/Makefile             |   1 +
>  arch/arm64/boot/dts/qcom/msm8976-leeco-s2.dts | 444 ++++++++++++++++++++++++++
>  2 files changed, 445 insertions(+)
> 
> +
> +	reserved-memory {
> +
> +		ramoops {

Nit: no empty line before it.

> +			compatible = "ramoops";
> +			no-map;
> +			reg = <0 0x9ff00000 0 0x100000>;

Please use 0x0 instead of 0.

> +			record-size = <0x10000>;
> +			console-size = <0x60000>;
> +			ftrace-size = <0x10000>;
> +			pmsg-size = <0x20000>;
> +			ecc-size = <16>;
> +		};
> +

[...]

> +
> +&mdss_dsi0 {
> +	vdd-supply = <&pm8950_l17>;
> +	vdda-supply = <&pm8950_l1>;
> +	vddio-supply = <&pm8950_l6>;
> +};
> +
> +&mdss_dsi0_out {
> +	data-lanes = <0 1 2 3>;

I think, you missed the panel here.

> +};
> +
> +&mdss_dsi0_phy {
> +	vddio-supply = <&pm8950_l6>;
> +};
> +
> +
> +&tlmm {
> +	gpio-reserved-ranges = <0 4>, <8 4>;
> +
> +	disp_reset_n_active: disp-reset-n-active-state {
> +		pins = "gpio25";
> +		function = "gpio";
> +		drive-strength = <8>;
> +		bias-disable;
> +		output-high;

Doesn't the driver also set output to high here?

> +	};
> +

-- 
With best wishes
Dmitry
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.