Re: [PATCH v5 4/5] media: qcom: camss: Add CAMSS Offline Processing Engine driver
Nihal Kumar Gupta <[email protected]>
| Newsgroups | org.kernel.vger.linux-hardening,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-media |
|---|---|
| Message-ID | <[email protected]> |
On 24-07-2026 18:12, Loic Poulain wrote:
> + .start_streaming = ope_start_streaming,
> + .stop_streaming = ope_stop_streaming,
> + .wait_prepare = vb2_ops_wait_prepare,
> + .wait_finish = vb2_ops_wait_finish,
> +};
Hi Loic,
While reviewing the series, I noticed that wait_prepare/wait_finish
callbacks and their helpers were removed in:
d0730006dac2 ("media: vb2: remove vb2_ops_wait_prepare/finish helpers")
b70886ff5833 ("media: vb2: drop wait_prepare/finish callbacks")
These stale lines are causing a compilation failure:
- .wait_prepare = vb2_ops_wait_prepare,
- .wait_finish = vb2_ops_wait_finish,
Please take care of this while posting next ver.
---
Regards,
Nihal Kumar Gupta