Re: [PATCH v2 1/6] dt-bindings: hwmon: add binding for adi,adt7470

Hi Luiz,

On Mon, Jul 20, 2026 at 11:12:49PM -0300, Luiz Angelo Daros de Luca wrote:
> Initially, I modeled the driver purely as a cooling device. However,
> following Sashiko-dev's suggestion in a previous review, I converted
> it to expose PWM channels so it could be used with the generic pwm-fan
> driver (which indeed makes the code cleaner). My primary experience is
> with DSA switches, so hwmon is a new area for me.

I like the driver exposing a generic PWM. For me it's quite in line with
the "Linux spirit" to do things with devices that are possible even if
that doesn't figure in the vendor's scheme.

> Whatever you and the DT maintainers agree on, I will gladly adjust for v3.

But my opinion doesn't count ... :-)

Best regards
Uwe

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmphsDwACgkQj4D7WH0S
/k7lqwf/Xq1hrcclNjopIUHYjq/ZmsRHMQe7JInwuovR5K1IvCOWdwrNpO1kvf34
MBP6lKRJPnSHpti2MrCXjqjaapLM2p55UQkLv2VYa4tYPHYnFYo4XAMFIYlSFJJI
9Im1yTxJmDM/jdk/taH6fimsu2ZOa9WLbz/2odo0XPVp/CeZqDyNofFGBDj8vmHC
Du66lLvLGRfbSUwv5flPopsJwL83jgiDzx/wDWadW6+M3oUVKh2LUIkjOjz6tthH
Wv2rEHQWRWZmf4cKJTOk69/VDovOtpelthr+1mZhkBmd/LYXID4O/ULmeUPg/GcP
ob+Uxidpj3bmhTls6SZK4u0gs5lZgg==
=PJzl
-----END PGP SIGNATURE-----