Re: [PATCH v5 1/2] dt-bindings: iio: adc: add maxim,max40080

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incomplete DT binding schema due to missing standard hardware properties
--

--- Patch [1]: [PATCH v5 1/2] dt-bindings: iio: adc: add maxim,max40080 ---
commit 613bf10ba7af5c378c448dbcf5f6af9c11712984
Author: Stefan Popa <[email protected]>

dt-bindings: iio: adc: add maxim,max40080

This commit adds device tree bindings for the Maxim MAX40080 bidirectional
current-sense amplifier. It defines standard properties and parameters like
the shunt resistor value used for scaling the reported current.

> diff --git a/Documentation/devicetree/bindings/iio/adc/maxim,max40080.yaml b/Documentation/devicetree/bindings/iio/adc/maxim,max40080.yaml
> new file mode 100644
> index 0000000000000..170bf4eff8706
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/maxim,max40080.yaml
[ ... ]
> +properties:
> +  compatible:
> +    const: maxim,max40080
> +
> +  reg:
> +    maxItems: 1
> +
> +  "#io-channel-cells":
> +    const: 1
> +
> +  shunt-resistor-micro-ohms:
> +    description:
> +      Value of the current-sense shunt resistor connected between the IN+ and
> +      IN- inputs. Used to scale the reported current.
> +
> +required:
> +  - compatible
> +  - reg
> +  - shunt-resistor-micro-ohms
> +
> +additionalProperties: false

[Severity: Low]
The commit message mentions an internal FIFO, which usually implies an
interrupt pin is available to signal data ready or alerts. Physical devices
also typically have power supply requirements, such as a vdd-supply.

Since additionalProperties is set to false, will device trees that accurately
describe these physical hardware connections fail schema validation? Should
definitions for interrupts or power supplies be added to the properties block
to bypass the additionalProperties restriction?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1