Re: [PATCH] hwmon: (pmbus/core) notify on the hwmon device, not the i2c client

Hi Bot,

> Pre-existing issues:
> - [High] Type confusion in pmbus_notify() causes out-of-bounds read and dropped hardware alarms.
  ...
> [Severity: High]
> This isn't a bug introduced by this patch, but I noticed a potential type
> confusion issue here while reviewing the notification logic.
> 
> Does the loop in pmbus_notify() safely handle heterogeneous attribute types?
  ...
> If so, it seems this could prematurely clear bits from flags via
> flags &= ~smask and silently drop legitimate hardware alarms before
> reaching the actual boolean alarm attribute.

It seems you are right and they are pre-existing behaviours.

However, this fix is independent of this behaviour. It moves
the notification target from i2c client kobject to the hwmon 
kobject device.

regards,
  Vincent

> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1