Re: [PATCH v2 2/2] hwmon: (pmbus/vt7505) Add driver for Analog Devices MAX16545/MAX16550 and Volterra VT7505

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `i2c_device_id` array does not use named (designated) initializers, violating I2C subsystem guidelines.
--

--- Patch [2]: [PATCH v2 2/2] hwmon: (pmbus/vt7505) Add driver for Analog Devices MAX16545/MAX16550 and Volterra VT7505 ---
commit 909ee10f8fd3e9cdfd9644221cb8eccdd4ef2cb0
Author: Georgi Vlaev <[email protected]>

hwmon: (pmbus/vt7505) Add driver for Analog Devices MAX16545/MAX16550 and Volterra VT7505

This commit adds a PMBus hardware monitoring driver for the Analog Devices
MAX16545, MAX16550, and Volterra VT7505 controllers. It supports reporting
and clearing peak values for voltage, current, power, and temperature.

> diff --git a/drivers/hwmon/pmbus/vt7505.c b/drivers/hwmon/pmbus/vt7505.c
> new file mode 100644
> index 0000000000000..a96abf75b1aad
> --- /dev/null
> +++ b/drivers/hwmon/pmbus/vt7505.c
[ ... ]
> +static const struct i2c_device_id vt7505_id[] = {
> +	{ "max16545", vt7505 },
> +	{ "max16550", max16550 },
> +	{ "vt7505", vt7505 },
> +	{ }
> +};

[Severity: Low]
Could these array entries be updated to use named (designated) initializers?
The I2C subsystem guidelines recommend using named initializers for arrays of
type struct i2c_device_id to maintain uniformity and prevent field
misalignment.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2