Re: [PATCH v3 1/3] hwmon: pmbus: event notification with alarms
| Newsgroups | org.kernel.vger.linux-hwmon,org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <[email protected]> |
> From: Vincent Jardin <[email protected]> > > Let's add an accessor for the hwmon class device the pmbus core > registered for an i2c_client. Export it with PMBUS so chip > drivers can call hwmon_notify_event() on per-sensor *_alarm > attributes from the driver's work items. > > The needs: for boards when the chip's SMBALERT# pin is > not available for the CPU, pmbus_irq_setup() cannot deliver > poll(POLLPRI) wakes or udev change@... events on the inX_alarm > files. So the drivers can install a delayed_work-based polling > fallback (like the lm90 driver) that periodically reads STATUS_WORD > and calls hwmon_notify_event() on 0->1 transitions. > > Signed-off-by: Vincent Jardin <[email protected]> Sashiko has reviewed this patch and found no issues. It looks great! -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1