Re: [PATCH v2 2/2] hwmon: (pmbus/vt7505) Add driver for Analog Devices MAX16545/MAX16550 and Volterra VT7505
"Pradhan, Sanman" <[email protected]>
| Newsgroups | org.kernel.vger.linux-hwmon,dev.linux.lists.sashiko-reviews,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-doc,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
From: Sanman Pradhan <[email protected]> On Thu, Jul 23, 2026 at 17:00:21 +0000, [email protected] wrote: > > +static const struct i2c_device_id vt7505_id[] = { > > + { "max16545", vt7505 }, > > + { "max16550", max16550 }, > > + { "vt7505", vt7505 }, > > + { } > > +}; > > [Severity: Low] > Could these array entries be updated to use named (designated) initializers? > The I2C subsystem guidelines recommend using named initializers for arrays of > type struct i2c_device_id to maintain uniformity and prevent field > misalignment. Thanks for the suggestion. I think the current initialization is valid across existing drivers for i2c_device_id. Since this looks like more of a style change, I can incorporate the designated initializers if another revision of the series becomes necessary. Thank you. Regards, Sanman Pradhan