Re: [PATCH v2 2/2] hwmon: (pmbus/vt7505) Add driver for Analog Devices MAX16545/MAX16550 and Volterra VT7505

On 7/23/26 14:30, Pradhan, Sanman wrote:
> From: Sanman Pradhan <[email protected]>
> 
> On Thu, Jul 23, 2026 at 17:00:21 +0000, [email protected] wrote:
>>> +static const struct i2c_device_id vt7505_id[] = {
>>> +	{ "max16545", vt7505 },
>>> +	{ "max16550", max16550 },
>>> +	{ "vt7505", vt7505 },
>>> +	{ }
>>> +};
>>
>> [Severity: Low]
>> Could these array entries be updated to use named (designated) initializers?
>> The I2C subsystem guidelines recommend using named initializers for arrays of
>> type struct i2c_device_id to maintain uniformity and prevent field
>> misalignment.
> 
> Thanks for the suggestion. I think the current initialization is valid
> across existing drivers for i2c_device_id.
> 

No, it isn't acceptable anymore. Existing drivers are all in the process
of being converted.

Guenter