Re: [PATCH v4 3/3] hwmon: pmbus: add MPQ8646 driver

Hi Guenter,

> Many if not all of those commands should really not be part of this driver,
> and commands such as probe_page_write would be extremely dangerous and
> mess up the driver if ever used.
> 
> Are you really sure you want to expose all those to the user, instead
> of (say) force them to use i2c_dev if they really want to risk turning
> the affected board(s) into a brick ?

your wise comment is welcomed. You are right, when I check the rationals why I did it:
it was related to some bring up issues I needed to debug and I thought first that
it would make sense to keep them in order to avoid loosing it, but the downside/risk
it not a good way to maintain it.

I'll propose a v6 with a removal of a part and with a CONFIG_SENSORS_MPQ8646_DEBUG_UNSAFE
for a reduced subset of those.

Best regards,
  Vincent