Re: [PATCH v5 3/3] hwmon: pmbus: add MPQ8646 driver
Guenter Roeck <[email protected]>
| Newsgroups | org.kernel.vger.linux-hwmon,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-doc,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 7/24/26 03:18, Vincent Jardin wrote:
> Hi Guenter,
>
>>> + for (i = 0; i < ARRAY_SIZE(mpq8646_alarm_map); i++) {
>>> + if (newly_set & mpq8646_alarm_map[i].mask)
>>> + hwmon_notify_event(priv->hwmon_dev,
>>> + mpq8646_alarm_map[i].type,
>>> + mpq8646_alarm_map[i].attr,
>>> + mpq8646_alarm_map[i].channel);
>>
>> This is wrong. This will require a new exported notification function
>> in pmbus code.
>
> OK, next, I'll try to factor the body of pmbus_fault_handler() into
> an exported helper, something like pmbus_check_and_notify_faults(client).
>
Yes, that is what I had in mind as well.
Thanks,
Guenter