Re: [PATCH v2 2/2] hwmon: (pmbus/vt7505) Add driver for Analog Devices MAX16545/MAX16550 and Volterra VT7505

From: Sanman Pradhan <[email protected]>

On Fri, Jul 24, 2026 at 06:15:35 -0700, Guenter Roeck wrote:
> On 7/24/26 02:03, Krzysztof Kozlowski wrote:
> > On Thu, Jul 23, 2026 at 04:43:59PM +0000, Pradhan, Sanman wrote:
> > > +enum chips { max16550, vt7505 };
> >
> > You must adjust to upstream kernel style and such constants/defines are
> > UPPER CASE
>
> No, you must not. Not in the hardware monitoring subsystem, where the
> chips enumeration is and always has been traditionally lower case.

Thanks for the reviews, Krzysztof and Guenter. I've tried to address
all the comments in v3.

Regarding adi,rload-ohms: after checking the datasheet more carefully,
this does not seem to be the same as the current-path sense resistor
that shunt-resistor-micro-ohms describes. These devices use integrated
lossless current sensing the ILOAD pin sources a small reporting
current proportional to the load current (typically 5 uA/A), and RLOAD
simply converts that reporting current into a voltage for telemetry
scaling. It does not carry the load current itself. I've kept the
device-specific property and tried to clarify this distinction in the
binding description.

I've also moved additionalProperties after the allOf block and added
adi,ocp-severe-filter-us to the example. The property is still
optional, when absent, the driver leaves the existing MFR_CONFIG
setting unchanged.

In the driver, I've replaced the raw enum match values with per-device
match data for MAX16545, MAX16550, and VT7505. This avoids the
zero-valued match data concern and removes the compatible-string check
from probe. The match data now carries the temperature coefficients and
a flag indicating whether the severe OCP filter is programmable.

Thank you.

Regards,
Sanman Pradhan