Re: [PATCH v5 1/2] dt-bindings: iio: adc: add maxim,max40080

On Thu, 23 Jul 2026 22:23:39 +0600
Siratul Islam <[email protected]> wrote:

> On Thu, 2026-07-23 at 09:50 +0300, Stefan Popa wrote:
> > Add device tree bindings for the Maxim MAX40080 bidirectional
> > current-sense amplifier with a 12-bit ADC and an I2C/SMBus interface.
> > 
> > Signed-off-by: Stefan Popa <[email protected]>
> > ---
> >   
> ...
> > +
> > +title: Maxim MAX40080 bidirectional current-sense amplifier
> > +
> > +maintainers:
> > +  - Ciprian Hegbeli <[email protected]>
> > +  - Stefan Popa <[email protected]>
> > +
> > +description: |
> > +  The MAX40080 is a high-precision, bidirectional current-sense amplifier with
> > +  an integrated 12-bit ADC and an I2C/SMBus interface. It measures the voltage
> > +  across an external shunt resistor and the input bus voltage, and stores the
> > +  results in an internal FIFO.
> > +
> > +  Datasheet:
> > +    https://www.analog.com/en/products/max40080.html  
> This URL links to a product page rather than a datasheet as the tag suggests.
> Would be difficult to fetch using CLI tools.
> Were you supposed to use something like
> "https://www.analog.com/media/en/technical-documentation/data-sheets/MAX40080.pdf"?

I think the argument for using product pages is that they are stable and datasheet
paths sometimes change.

For ADI there is a neater form as well that is supposed to be stable (and
has been for last few years at least)
https://www.analog.com/max40080
Works for any product and takes you to the equilvalent product page to the
link above.

So whilst you make a good point I think we will have to let Analog decide
on a standard way to link to their product info / datasheets.  That is
on the perhaps optimistic basis they have more insight into stable choices
than we do!

> 
> > +
> >   
> ...
> > +examples:
> > +  - |
> > +    i2c {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        adc@20 {
> > +            compatible = "maxim,max40080";
> > +            reg = <0x20>;
> > +            #io-channel-cells = <1>;
> > +            shunt-resistor-micro-ohms = <100000>;
> > +        };
> > +    };  
> 
> --
> Best regards,
> Sirat
>