Re: [PATCH v2] hwmon: (lm63) Mask PWM frequency multiplier to supported bits
[email protected] Mon, 27 Jul 2026 21:24:20 +0000
| Newsgroups | org.kernel.vger.linux-hwmon |
|---|---|
| Message-ID | <[email protected]> |
> Sashiko is concerned that reading a PWM frequency multiplier outside > the supported range of [1, 31] might result in bad PWM values written > to the chip. Technically, the chip should never return a value with > the upper 3 bits set, so this should never happen. However, it is > unknown if there are LM63 variants where the upper bits of the register > can be written. > > Mask the register value read from the chip to only accept the lower 5 bit > when reading it from the chip to avoid the problem. > > Reported-by: Sashiko <[email protected]> > Signed-off-by: Guenter Roeck <[email protected]> Sashiko has reviewed this patch and found no issues. It looks great! -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1