Re: [PATCH 4/5] dt-bindings: hwmon/pmbus: Document MAX20826 and similar devices

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] Missing Regulator Subnodes for Dual Rails
- [High] Missing Power Supply Properties
--

--- Patch [4]: [PATCH 4/5] dt-bindings: hwmon/pmbus: Document MAX20826 and similar devices ---
commit 2b08f009cb35e4f4f84d9a87d92b4afdc5d9b230
Author: Nuno Sá <[email protected]>

dt-bindings: hwmon/pmbus: Document MAX20826 and similar devices

This commit introduces device tree bindings for the Analog Devices MAX20826
and similar dual-loop multiphase high-current PMBus voltage regulators. It
defines the schema for the compatible strings, registers, and enable GPIOs.

> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/adi,max20826.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/adi,max20826.yaml
> new file mode 100644
> index 0000000000000..6d280f8bf56bd
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/adi,max20826.yaml

[ ... ]

> +  reg:
> +    maxItems: 1
> +
> +  avren-gpios:
> +    description: GPIO pin to enable/disable the output voltage on Rail A.
> +    maxItems: 1
> +
> +  bvren-gpios:
> +    description: GPIO pin to enable/disable the output voltage on Rail B.
> +    maxItems: 1

[Severity: High]
Should this binding use standard regulator child subnodes instead of defining
custom avren-gpios and bvren-gpios at the parent level?

Because additionalProperties is set to false below, standard regulator
subnodes are rejected. This prevents consumers from defining standard
regulator constraints like regulator-min-microvolt and bypasses the
built-in pmbus core support for parsing standard regulators.

Would it be better to model this with standard regulator child nodes using
enable-gpios?

> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false

[Severity: High]
Does this binding need to document standard input power supply properties?

Since additionalProperties is false, board device trees are prohibited from
specifying upstream parent supplies (like vin-supply or vcc-supply). This
could prevent the regulator framework from modeling the power tree, which
might break power sequencing if the parent supply needs to be enabled
before this controller operates.

Should standard input supply properties be permitted here?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=4