Re: [PATCH 1/5] hwmon: (pmbus/core) fix regulator enable/disable

[email protected] Tue, 28 Jul 2026 16:22:33 +0000
Newsgroups org.kernel.vger.linux-hwmon,org.kernel.vger.linux-devicetree
Message-ID <[email protected]>
> From: Nuno Sá <[email protected]>
> 
> pmbus_update_byte_data() can return the value of PMBUS_OPERATION which
> can be different than 0 and that can mess with the regulator core
> given _regulator_disable() explicitly checks for ret == 0 in order to
> call _regulator_handle_consumer_disable().
> 
> Fixes: ddbb4db4ced1 ("hwmon: (pmbus) Add regulator support")
> Signed-off-by: Nuno Sá <[email protected]>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1