Re: [PATCH 1/5] hwmon: (pmbus/core) fix regulator enable/disable
Guenter Roeck <[email protected]> Tue, 28 Jul 2026 09:58:12 -0700
| Newsgroups | org.kernel.vger.linux-hwmon,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-doc |
|---|---|
| Message-ID | <[email protected]> |
On 7/28/26 09:03, Nuno Sá via B4 Relay wrote: > From: Nuno Sá <[email protected]> > > pmbus_update_byte_data() can return the value of PMBUS_OPERATION which > can be different than 0 and that can mess with the regulator core > given _regulator_disable() explicitly checks for ret == 0 in order to > call _regulator_handle_consumer_disable(). > > Fixes: ddbb4db4ced1 ("hwmon: (pmbus) Add regulator support") > Signed-off-by: Nuno Sá <[email protected]> The real problem is that pmbus_update_byte_data() should only return 0 or an error code. The fix is in the "hwmon" branch and should be upstream by the end of the week. Guenter