Re: [PATCH v3 2/3] hwmon: (emc1403) Convert to use OF bindings

Uwe Kleine-König <[email protected]> Tue, 28 Jul 2026 23:44:13 +0200

Newsgroups	org.kernel.vger.linux-hwmon,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel
Message-ID	<amUz_ilAvq_fBHld@monoceros>

On Sat, Jul 25, 2026 at 07:23:13AM -0700, Guenter Roeck wrote:
> On 7/25/26 06:24, Svyatoslav Ryhel wrote:
> > чт, 23 лип. 2026 р. о 09:28 Uwe Kleine-König
> > <[email protected]> пише:
> > > 
> > > Hello,
> > > 
> > > On Tue, Jul 21, 2026 at 12:59:34PM +0300, Svyatoslav Ryhel wrote:
> > > > From: Jonas Schwöbel <[email protected]>
> > > > 
> > > > Add OF match compatible table to be able to use this driver with Device
> > > > Trees.
> > > > 
> > > > Signed-off-by: Jonas Schwöbel <[email protected]>
> > > > Signed-off-by: Svyatoslav Ryhel <[email protected]>
> > > > Reviewed-by: Guenter Roeck <[email protected]>
> > > 
> > > Please put your S-o-b line last.
> > > 
> > 
> > If S-o-b's should be chronological, then this order is correct.
> > Guenter added his reviewed-by after I have added my signed-off-by.

It's a nitpick, but as you added Guenter's tag, you modified the commit
log and then your S-o-b has to be renewed. 

> That refers to S-o-B, not to Reviewed-by: trailers.
> 
> Do we really have to argue about something like this ? Do I have
> to mandate the order of non-SoB trailers for this subsystem ?

I wouldn't have replied just for the order, but I think it's convenient
and usual to have the own S-o-b last.

Depends on you how strict you want to be here, as usual. I for my part
ask for reordering or announce to fix the ordering if nothing else is in
the way for application.

Best regards
Uwe

signature.asc (application/pgp-signature, 488 B)