Re: [PATCH v5 4/4] hwmon: (pmbus/max20830): add support for max20830c and max20840c

On 7/29/26 18:14, [email protected] wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [High] The patch adds support for MAX20830C and MAX20840C devices but fails to add their corresponding compatible strings and I2C IDs to the driver's match tables.
> --
> 
> --- Patch [4]: [PATCH v5 4/4] hwmon: (pmbus/max20830): add support for max20830c and max20840c ---
> commit f53870a8f52f5aa8dbc791f9a7e148eeab915f24
> Author: Alexis Czezar Torreno <[email protected]>
> 
> hwmon: (pmbus/max20830): add support for max20830c and max20840c
> 
> Add support for MAX20830C and MAX20840 step-down DC-DC switching regulator
> with PMBus interface. MAX20830C is a different packaging for MAX20830, and
> MAX20840C supports 40A regulation compared to MAX20830 that is only 30A.
> 
>> diff --git a/drivers/hwmon/pmbus/max20830.c b/drivers/hwmon/pmbus/max20830.c
>> index ddead72a8db5d..94433deda0113 100644
>> --- a/drivers/hwmon/pmbus/max20830.c
>> +++ b/drivers/hwmon/pmbus/max20830.c
>> @@ -21,6 +21,12 @@ struct max20830_data {
>>   	u32 vout_rfb2;
>>   };
>>   
>> +static const char * const supported_chip_ids[] = {
>> +	"MAX20830",
>> +	"MAX20830C",
>> +	"MAX20840C",
>> +};
> 
> [Severity: High]
> While the new chips are added to the internal string matching list here, does
> the driver also need to add these to max20830_id and max20830_of_match?
> 
> Without the new compatible strings in these tables, won't the devices fail
> to bind to the driver when instantiated via Device Tree?
> 
> For reference, the existing tables at the bottom of the driver only have
> entries for the original chip:
> 

Sashiko is getting a bit confused. Patch is ok as-is.

Guenter

> static const struct i2c_device_id max20830_id[] = {
> 	{"max20830"},
> 	{ }
> };
> 
> static const struct of_device_id max20830_of_match[] = {
> 	{ .compatible = "adi,max20830" },
> 	{ }
> };
>