Re: [PATCH v6 2/4] dt-bindings: hwmon: pmbus: add MPS MPQ8646
Vincent Jardin <[email protected]> Thu, 30 Jul 2026 08:55:38 +0200
| Newsgroups | org.kernel.vger.linux-hwmon,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-doc,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Hi Guenter, Le 29/07/26 21:10, Guenter Roeck a écrit : > On 7/29/26 14:51, Vincent Jardin via B4 Relay wrote: > > From: Vincent Jardin <[email protected]> > > > > The MPS MPQ8646 PMBus step-down converter uses the same > > mps,vout-fb-divider-ratio-permille property with the same constraints > > (maximum 2047, default 706) as the mps,mpq8785, so add its compatible > > to the existing schema. > > > > The driver is a separate driver, making this a bit unusual. > I'll leave it up to the devicetree maintainers to decide if > this should be a new bindings file or not. Because of Krzysztof's review of v5: he asked exactly for it since mps,mpq8785.yaml already carries the same property, the same constraints and the same defaults: see https://lore.kernel.org/all/20260727-sceptical-finicky-waxbill-d7ecbf@quoll/ "...Everything is the same as mps,mpq8785.yam, so why it cannot be added there? Just grow the list of if:then: to cover your specific constraints." v5 had it as a separate mps,mpq8646.yaml file. I'll follow whatever the DT maintainers prefer, but so should we consider that it complies with Krzysztof's argument ? Best regards, Vincent