Re: [PATCH v2 01/10] dt-bindings: hwmon: Describe Qualcomm BCL hardware

Hi Krzystof,


On 7/23/26 10:11, Krzysztof Kozlowski wrote:
> On Wed, Jul 22, 2026 at 12:00:06AM +0530, Manaf Meethalavalappu Pallikunhi wrote:
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - qcom,pm7250b-bcl
>> +      - qcom,pm8350c-bcl
>> +      - qcom,pm8550-bcl
>> +      - qcom,pmh0101-bcl
>> +      - qcom,pmih0108-bcl
>> +      - qcom,smb2360-bcl
>> +      - qcom,smb2370-bcl
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  interrupts:
>> +    maxItems: 2
>> +
>> +  interrupt-names:
>> +    items:
>> +      - const: max-min
>> +      - const: critical
>> +
> 
> Binding looks in general ok, but feels incomplete. If this is battery
> limiting hardware, does it actually need any battery data through
> monitored-battery property?

I'm not sure it is relevant here. The BCL is not a power supply neither 
a charger. It monitors a power supply output which can be a battery or 
another source of power AFAIU.

The monitored-battery property is used by chargers or fuel gauges if I 
refer to the documentation.

The BCL monitors the output of the power supply while the chargers 
monitors the input for the battery.

Manaf, does it sound correct ?