Re: [PATCH v6 1/2] dt-bindings: iio: adc: add adi,max40080
[email protected] Thu, 30 Jul 2026 13:25:23 +0000
| Newsgroups | org.kernel.vger.linux-hwmon,org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <[email protected]> |
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The MAINTAINERS entry for 'MAXIM MAX40080 CURRENT SENSE AMPLIFIER DRIVER' is incorrectly appended to the very end of the file, placing it after the catch-all 'THE REST' section. -- --- Patch [1]: [PATCH v6 1/2] dt-bindings: iio: adc: add adi,max40080 --- commit 4f01f75006cab658c6276517a4096c41a91e9b17 Author: Stefan Popa <[email protected]> dt-bindings: iio: adc: add adi,max40080 This commit adds device tree bindings for the Analog Devices MAX40080 bidirectional current-sense amplifier. It outlines the required properties and creates a new maintainer entry for the driver. > diff --git a/MAINTAINERS b/MAINTAINERS > --- a/MAINTAINERS > +++ b/MAINTAINERS [ ... ] > @@ -27447,3 +27447,11 @@ S: Buried alive in reporters > T: git git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > F: * > F: */ > + > +MAXIM MAX40080 CURRENT SENSE AMPLIFIER DRIVER [Severity: Low] This isn't a bug, but should this new entry be sorted alphabetically within the file? Appending it at the very bottom places it after the catch-all fallback section, which violates the standard sorting convention. > +M: Ciprian Hegbeli <[email protected]> > +M: Stefan Popa <[email protected]> > +L: [email protected] > +S: Supported > +W: https://ez.analog.com/linux-software-drivers > +F: Documentation/devicetree/bindings/iio/adc/adi,max40080.yaml -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1