Re: [PATCH] hwmon: dell-smm-hwmon: Add fan control for OptiPlex Micro 7020

Am 02.08.26 um 23:03 schrieb Jonas Haugk:

> Add the Dell OptiPlex Micro 7020 to the fan control whitelist using
> the 0x34a3/0x35a3 SMM command pair.
>
> Manual fan control was tested successfully with PWM values 64, 128,
> and 255. The fan speed changed accordingly. Restoring automatic BIOS
> fan control through pwm1_enable also worked correctly.
>
> Tested on a Dell OptiPlex Micro 7020.

Hi,

can you check if the I8K_FAN_30A3_31A3 pair also work? AFAIK this pair
is being used by recent releases of the OEM software, so i would prefer
using it.

Thanks,
Armin Wolf

>
> Signed-off-by: Jonas Haugk <[email protected]>
> ---
>   drivers/hwmon/dell-smm-hwmon.c | 9 +++++++++
>   1 file changed, 9 insertions(+)
>
> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwm=
on.c
> index 20920d4bd..23773421a 100644
> --- a/drivers/hwmon/dell-smm-hwmon.c
> +++ b/drivers/hwmon/dell-smm-hwmon.c
> @@ -1655,6 +1655,15 @@ static const struct dmi_system_id i8k_whitelist_f=
an_control[] __initconst =3D {
>   		},
>   		.driver_data =3D (void *)&i8k_fan_control_data[I8K_FAN_30A3_31A3],
>   	},
> +	{
> +		.ident =3D "Dell OptiPlex Micro 7020",
> +		.matches =3D {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_EXACT_MATCH(DMI_PRODUCT_NAME,
> +					"OptiPlex Micro 7020"),
> +		},
> +		.driver_data =3D (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
> +	},
>   	{ }
>   };
>  =20