Re: [PATCH 0/3] hwmon: (ltc4282) Fix issues reported by Sashiko

Nuno Sá <[email protected]> Wed, 5 Aug 2026 10:26:54 +0100
Newsgroups org.kernel.vger.linux-hwmon
Message-ID <anMA34nFCvAQUk6V@nsa>
On Tue, Aug 04, 2026 at 05:57:18PM -0700, Guenter Roeck wrote:
> This series started with a patch fixing a potential overflow issue in
> maximum poer calculations. Sashiko then reported a similar problem when
> setting current limits, and finally found a problem when evaluating
> adi,current-limit-sense-microvolt.
> 
> This series fixes all those problems.
> 
> Note that Sashiko reports more issues in this driver. Leave those
> to be fixed later.
> 
> ----------------------------------------------------------------
> Guenter Roeck (3):
>       hwmon: (ltc4282) Avoid overflow in maximum power calculation
>       hwmon: (ltc4282) Clamp negative current limits
>       hwmon: (ltc4282) Fix parsing adi,current-limit-sense-microvolt
> 
>  drivers/hwmon/ltc4282.c | 20 ++++++++++++--------
>  1 file changed, 12 insertions(+), 8 deletions(-)

Hi Guenter,

During ltc4283 sashiko's review was clear to me that this one also needed some
attention but no time for it so far. So thanks for this.

Also, the clk_init_data remark is very much an issue. Not sure if you
can fit that in this series. Or I can also send a quick patch for it.

Regarding the series, just one suggestion from me. With that:

Reviewed-by: Nuno Sá <[email protected]>