Re: [PATCH 1/2] dt-bindings: hwmon: add Axiado AX3000 and AX3005 PWM fan controller

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The devicetree binding schema misses standard fan cooling properties (`#cooling-cells` and `cooling-levels`), breaking thermal zone integration.
--

--- Patch [1]: [PATCH 1/2] dt-bindings: hwmon: add Axiado AX3000 and AX3005 PWM fan controller ---
commit 34174063599786fae2685438f00eb273f5ba7c0b
Author: Petar Stepanovic <[email protected]>

dt-bindings: hwmon: add Axiado AX3000 and AX3005 PWM fan controller

This commit adds a devicetree binding for the PWM fan controller on Axiado
AX3000 and AX3005 SoCs, which uses a hardware tachometer and external PWM
controller. It also updates the MAINTAINERS file.

> diff --git a/Documentation/devicetree/bindings/hwmon/axiado,ax3000-pwm-fan.yaml b/Documentation/devicetree/bindings/hwmon/axiado,ax3000-pwm-fan.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/axiado,ax3000-pwm-fan.yaml

[ ... ]

> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks
> +  - pwms
> +
> +additionalProperties: false

[Severity: Medium]
Does this strict property check prevent thermal zone integration? 

Setting additionalProperties to false without a reference to fan-common.yaml#
or explicitly allowing #cooling-cells and cooling-levels will cause schema
validation to fail if standard fan cooling properties are added. 

A devicetree node attempting to integrate this fan controller into a thermal
cooling-maps block will fail dtbs_check with a 'node has property not allowed
by schema' error.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1