Re: [PATCH 1/2] dt-bindings: hwmon: add Axiado AX3000 and AX3005 PWM fan controller

On Thu, Aug 06, 2026 at 02:01:29AM -0700, Petar Stepanovic wrote:
> Add a Devicetree binding for the PWM fan controller found on the
> Axiado AX3000 and AX3005 SoCs.
> 
> The controller measures fan speed using a hardware tachometer block.
> Fan speed is controlled through a PWM signal supplied by an external
> PWM controller.
> 
> Add a MAINTAINERS entry for the binding.
> 
> Signed-off-by: Petar Stepanovic <[email protected]>
> ---
>  .../bindings/hwmon/axiado,ax3000-pwm-fan.yaml      | 68 ++++++++++++++++++++++
>  MAINTAINERS                                        |  8 +++
>  2 files changed, 76 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/axiado,ax3000-pwm-fan.yaml b/Documentation/devicetree/bindings/hwmon/axiado,ax3000-pwm-fan.yaml
> new file mode 100644
> index 000000000000..a985f49bbdcd
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/axiado,ax3000-pwm-fan.yaml
> @@ -0,0 +1,68 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/axiado,ax3000-pwm-fan.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Axiado AX3000 and AX3005 PWM Fan Controller
> +
> +maintainers:
> +  - Petar Stepanovic <[email protected]>
> +  - Akhila Kavi <[email protected]>
> +  - Prasad Bolisetty <[email protected]>
> +
> +description:
> +  The Axiado AX3000 and AX3005 fan controllers use a hardware tachometer
> +  block to measure fan speed. Fan speed is controlled through a PWM signal
> +  supplied by an external PWM controller.
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - const: axiado,ax3000-pwm-fan
> +      - items:
> +          - const: axiado,ax3005-pwm-fan
> +          - const: axiado,ax3000-pwm-fan
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  pwms:
> +    maxItems: 1
> +    description:
> +      PWM specifier used to control fan speed.
> +
> +  pulses-per-revolution:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    minimum: 1
> +    default: 2
> +    description:
> +      Number of tachometer pulses generated per fan revolution.

This is a property of a fan, not the fan controller. The fan(s) should 
be represented as child node(s) under this device. Use the common fan 
binding, fan-common.yaml. See other bindings using it.

Rob