Re: [PATCH] hwmon: (yogafan) Add support for new Lenovo models
Sergio Melas <[email protected]>
| Newsgroups | org.kernel.vger.linux-hwmon,dev.linux.lists.sashiko-reviews |
|---|---|
| Message-ID | <CAP8e=sJbD21FyeU+9w_CVGLOXhxdWmsCwcrS5uNB0Z+9qQ4gLQ@mail.gmail.com> |
Hi Guenter, Confirming that at my knowledge this is a non-issue. However, using the 4-letter machine type code DMI_PRODUCT_NAME could theoretically offer even tighter precision, but up to now, the current matching method has never failed in our testing and field deployment users of my github: https://github.com/sergiomelas/lenovo-linux-drivers/tree/main Anyway, I am compiling a full database for complete data of Lenovo machines from PSREF: https://psref.lenovo.com/ For reference, the complete mapping matrix and DSDT traces can be found in the Yogafan Master Quirk Database. My database on based on this source and others is here: https://github.com/sergiomelas/lenovo-linux-drivers/blob/main/Lenovo_Drivers/Prototype/PSREF/yogafan_v3_quirks_database.ods and https://github.com/sergiomelas/lenovo-linux-drivers/tree/main/Lenovo_Drivers/Prototype/DSDT I propose to switch to this identification method when we have more machine references. What do yo think? Thanks, Sergio On Thu, Aug 6, 2026 at 5:44 PM Guenter Roeck <[email protected]> wrote: > > Sergio, > > On 8/6/26 06:24, [email protected] wrote: > > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: > > - [High] Specific Lenovo model DMI quirks incorrectly use `DMI_PRODUCT_FAMILY` for exact model string matching, causing all specific quirks to fail and fall back to incorrect generic profiles. > > -- > > Please confirm that this is a non-issue. > > Thanks, > Guenter >